Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase TLSPolicy timeout for Azure TLS ACME challenges #629

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Increase TLSPolicy timeout for Azure TLS ACME challenges #629

merged 1 commit into from
Feb 6, 2025

Conversation

averevki
Copy link
Contributor

Azure TLS ACME challenges take 7+ minutes on the multiclusters

@averevki averevki added the bug Something isn't working label Jan 30, 2025
@averevki averevki self-assigned this Jan 30, 2025
trepel
trepel approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - downside is that this increases the timeout for TLSPolicy in general, not only for Azure but I agree that it is not worth the effort to try to implement this for Azure only.

@trepel trepel merged commit 1a6722d into Kuadrant:main Feb 6, 2025
3 checks passed
@averevki averevki deleted the increase-tls-timeout-azure branch February 6, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepel trepel trepel approved these changes

Assignees

@averevki averevki

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averevki @trepel